fix: Configure-Xcode-Simulators duplicate removal logic#13836
Open
PrashantRaj18198 wants to merge 1 commit intoactions:mainfrom
Open
fix: Configure-Xcode-Simulators duplicate removal logic#13836PrashantRaj18198 wants to merge 1 commit intoactions:mainfrom
PrashantRaj18198 wants to merge 1 commit intoactions:mainfrom
Conversation
There is a case where some duplicate xcode simulators are being missed. Case: Here A and B are simulators and the numeric values are time. [ A:0, A:1, A:2, B:0, B:1 ] Current, case i=0, compares A:0, A:1 and removes A:1, array now [ A:0, A:2, B:0, B:1 ]. But we also increment i at the end of the loop so i moves to 1. i=1, checks A:2 againsts B:0 which is ok. But multiple simulators for A are still present. The updated code basically updates i only if no simulator matches were found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug fix -- configure xcode simulators sometimes leaves duplicate entries
There is a case where some duplicate xcode simulators are being missed.
The updated code basically updates i only if no simulator matches were found.
We can close this PR and do the co-author thing since this is a macos contribution
For new tools, please provide total size and installation time.
Related issue:
Check list